Manchester | 26-ITP-Jan | Ahmed Elmahmoudi | Sprint 1 | Feature Wireframe #1100
Open
Alaterry8 wants to merge 9 commits intoCodeYourFuture:mainfrom
Open
Manchester | 26-ITP-Jan | Ahmed Elmahmoudi | Sprint 1 | Feature Wireframe #1100Alaterry8 wants to merge 9 commits intoCodeYourFuture:mainfrom
Alaterry8 wants to merge 9 commits intoCodeYourFuture:mainfrom
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Alaterry8
added
the
Needs Review
Alaterry8
changed the title
Alaterry8
changed the title
Alaterry8
added
📅 Sprint 1
cjyuan
reviewed
Feb 5, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Code is free of syntax errors and well indented. Well done.
1
When a wireframe is provided, our implementation should closely reflect its appearance and layout to ensure consistency with design expectations. You're off to a solid start. To better align with the wireframe, can you
- Center the PAGE TITLE and the SHORT DESCRIPTION beneath it
- Center the text on the footer
?
2
Can you improve the Lighthouse accessibility score to 100?
3
The footer content and the article content could overlap when the user scrolls the content. Can you address this issue (to improve user experience)?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
I added 3 new articles that contain titles, summaries, images and links. I styled the articles with CSS to change the background colour. I changed the footer colour.